[Webkit-unassigned] [Bug 46335] Add EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46335





--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2010-11-04 17:40:35 PST ---
(In reply to comment #16)
> Created an attachment (id=73014)
 --> (https://bugs.webkit.org/attachment.cgi?id=73014&action=review) [details]
> fixed the crash on fast/events/keydown-function-keys.html

I'm pretty sure this test didn't crash when I uploaded the original patch but the problem was with instantiating EditingStyle in the constructor of EditingStyle.  m_typingStyle somehow reset the ref counter of the mutable style to 0 after returning from EditingStyle::create.  Avoiding to instantiate EditingStyle inside SelectionController::SelectionController fixed this problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.