[Webkit-unassigned] [Bug 48809] Chromium WebKit API needs WebFrame::lastCommittedHistoryItem()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48809





--- Comment #6 from Charles Reis <creis at chromium.org>  2010-11-04 16:16:46 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > My test in http://codereview.chromium.org/4444001/show is showing that won't work.  m_frame->loader()->history()->currentItem() is returning the item for the navigation that's currently in progress, not the last committed item.  As a result, all the UpdateState messages are sending state from the page that's about to commit, rather than the one that's about to be replaced.
> > 
> > Is there another way to get at the history item for the last committed navigation?
> 
> In that case, wouldn't the previousHistoryItem provide you with what you need?  The previousHistoryItem is the HistoryItem that was previously current.  So, if the currentHistoryItem is the new item, then the previousHistoryItem should be the one you need, no?

Here's the scenario:
 - Visit pages A, B, C
 - Quickly press back twice (to B and then to A), before B has a chance to commit.

At this point in time, A is the current item, B is the previous item, and C is the last committed item.  I need a way to get to C.  Note that there may be an arbitrary number of pages like B (between previous and last committed), if you hold down the back button and race past several entries.

The original bug is that we were using the previous item, which was giving us B, but the last committed page ID (corresponding to C).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.