[Webkit-unassigned] [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48781


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72676|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2010-11-04 15:51:42 PST ---
(From update of attachment 72676)
View in context: https://bugs.webkit.org/attachment.cgi?id=72676&action=review

Should we test what happens when you return false from this delegate call?

> WebCore/loader/CachedImage.cpp:233
> +    if (!frame || !frame->loader())

Frames always have loaders.  There's no need to null check it.

> WebCore/loader/CachedImage.cpp:236
> +    KURL imageURL(ParsedURLString, m_url);

Why do we define this local variable and then not use it?

> WebCore/loader/CachedImage.cpp:302
> +            int errorCode = ImageErrorUnknown;
> +            if (m_image->isNull())
> +                errorCode = ImageErrorUnableToDecode;
> +            else
> +                errorCode = ImageErrorImageTooBig;

This seems like it should be a member function that returns the errorCode()

> WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:938
> +}

missing blank line after this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.