[Webkit-unassigned] [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item

Thu Nov 4 15:12:38 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=48812

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72886|review?                     |review-
               Flag|                            |

--- Comment #13 from Adam Barth <abarth at webkit.org>  2010-11-04 15:12:38 PST ---
(From update of attachment 72886)
View in context: https://bugs.webkit.org/attachment.cgi?id=72886&action=review

> WebCore/loader/FrameLoader.cpp:2385
> +                    // Do not change the history if the backForward controller
> +                    // is aleady loading a new URL.
> +                    if (pdl->request().url() == page->backForward()->currentItem()->url()) {

URL can't be the right thing to use here.  What if all the pages in the back-forward list have the same URL?  Wouldn't that case still have the corruption?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.