[Webkit-unassigned] [Bug 48865] [GTK] Link with target name set does not work correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48865


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72955|review?                     |review-
               Flag|                            |




--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2010-11-04 14:58:54 PST ---
(From update of attachment 72955)
View in context: https://bugs.webkit.org/attachment.cgi?id=72955&action=review

Great! Is it possible to go one step further and remove webkit_web_view_set_group_name from webkitwebview.cpp entirely, since, if I understand correctly, it is now dead code.

> WebKit/gtk/webkit/webkitwebview.cpp:3250
> +    priv->corePage->setGroupName("WebKitGTK");

I think we should have a comment here explaining why this is necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.