[Webkit-unassigned] [Bug 49027] New: video controls RenderReplaced::layout() calls setNeedsLayout(false) while its children still need layout

Thu Nov 4 14:30:57 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=49027

           Summary: video controls RenderReplaced::layout() calls
                    setNeedsLayout(false) while its children still need
                    layout
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jamesr at chromium.org
                CC: hyatt at apple.com, mitz at webkit.org,
                    eric.carlson at apple.com, simon.fraser at apple.com
            Blocks: 49019

The ASSERT()s in https://bugs.webkit.org/show_bug.cgi?id=49019 trigger on the following HTML:

<!DOCTYPE html>
<video controls></video>

as well as most of the media/ tests.  The render tree looks something like this:

RenderView 0x3dc3cd8                       #document    0x3dfed20
  RenderBlock 0x3e3c968                    HTML    0x3e3bf40
    RenderBody 0x3e37968                   BODY    0x3e3cd90
      RenderVideo 0x3e4aa88                VIDEO    0x3e37a30
*       RenderBlock (relative positioned) 0x3e4ae48    DIV    0x3e38950
          RenderFlexibleBox (positioned) 0x3e48308    DIV    0x3e4b050
            RenderButton 0x3e48808         INPUT    0x3e4c610
            RenderFlexibleBox (positioned) 0x3e48ea8    DIV    0x3e4cb90
              RenderBlock (positioned) 0x3e49438    DIV    0x3e4cc30
                RenderText 0x3db0ed8       #text    0x3db0e50 "00:00"
              RenderSlider 0x3e499a8       INPUT    0x3e4ccd0
                RenderBlock 0x3db0a08      DIV    0x3db01f0
            RenderButton 0x3dafb88         INPUT    0x3e476d0

The RenderBlock root of the controls is marked as m_needsLayout=true, m_normalChildNeedsLayout=true, m_posChildNeedsLayout=true at the end of RenderReplaced::layout() on its parent RenderVideo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.