[Webkit-unassigned] [Bug 49008] Unbounded memory growth for long lived pages with many requests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 4 10:58:55 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=49008
Adam Barth <abarth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72962|review? |review-
Flag| |
--- Comment #4 from Adam Barth <abarth at webkit.org> 2010-11-04 10:58:55 PST ---
(From update of attachment 72962)
View in context: https://bugs.webkit.org/attachment.cgi?id=72962&action=review
> WebCore/loader/Cache.cpp:802
> +SubCache::SubCache() : m_cache(cache())
The ": m_cache(cache())" part should be on its own line and indented four spaces.
> WebCore/loader/Cache.cpp:813
> +CachedResource*
> +SubCache::resourceForURL(const String &url) const
The return type should be on the same line as the function declaration. Also, I don't see where this function is called.
> WebCore/loader/Cache.cpp:825
> +void
> +SubCache::add(const String &url)
> +{
> + if (m_cache->resourceForURL(url)) // It must be in the cache for it to go into the subcache.
> + m_resources.add(url);
> +}
Where is this function called?
> WebCore/loader/Cache.h:241
> +class SubCache {
This should be in its own file. Also, we should think of a more descriptive name.
> WebCore/loader/Cache.h:243
> +public:
> +
No blank line here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list