[Webkit-unassigned] [Bug 45101] [GStreamer] ::buffered() should return multiple ranges in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 4 10:13:49 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
  Attachment #72950|review?                     |review+
               Flag|                            |

--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2010-11-04 10:13:49 PST ---
(From update of attachment 72950)
View in context: https://bugs.webkit.org/attachment.cgi?id=72950&action=review

Looks good overall. I'd just recommend doing the check for having exactly 2 buffered ranges, like we discussed on IRC.

> WebCore/platform/gtk/RenderThemeGtk.cpp:934
> +            rangeRect.setLocation(IntPoint(trackRect.x() + (start / mediaDuration)* totalWidth , trackRect.y()));

I believe you should not need the parens here, or else put the multiplication inside it, any of them would make the code more obvious to me. Also, there's a rogue space before the ',' =)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list