[Webkit-unassigned] [Bug 48515] [NRWT] Clear invalid http locks on Windows platform as well

Thu Nov 4 08:42:04 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=48515

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72944|review?                     |review+
               Flag|                            |

--- Comment #13 from Eric Seidel <eric at webkit.org>  2010-11-04 08:42:03 PST ---
(From update of attachment 72944)
View in context: https://bugs.webkit.org/attachment.cgi?id=72944&action=review

This looks great!  Thank you!

We could break the windows check_running_pid out into a helper _win32_check_running_pid() method since it's so long.  But it's also probably OK for now as is.

> WebKitTools/Scripts/webkitpy/common/system/executive.py:252
> +

We should probably assert(false) here, since we're handling a case we dont' expect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.