[Webkit-unassigned] [Bug 48985] [Qt][WK2] Left over files and shared memory segments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48985


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72928|review?                     |review-
               Flag|                            |




--- Comment #4 from Andreas Kling <kling at webkit.org>  2010-11-04 06:34:26 PST ---
(From update of attachment 72928)
View in context: https://bugs.webkit.org/attachment.cgi?id=72928&action=review

Looks good in general, some problems though:

> WebKit2/Shared/qt/CrashHandler.cpp:38
> +CrashHandler::CrashHandler()
> +{

Missing initialization of m_inDeleteObjects!

> WebKit2/Shared/qt/CrashHandler.cpp:41
> +    signal(SIGABRT, &CrashHandler::signalHandler);
> +    signal(SIGSEGV, &CrashHandler::signalHandler);
> +    signal(SIGINT, &CrashHandler::signalHandler);

You probably want to catch SIGFPE, SIGILL, SIGQUIT, SIGTRAP and SIGBUS as well here.

> WebKit2/Shared/qt/CrashHandler.cpp:54
> +    foreach(QObject* object, m_objects)
> +        delete object;

qDeleteAll(m_objects);

> WebKit2/Shared/qt/CrashHandler.h:48
> +    void addToDeletion(QObject* object)

addToDeletion() sounds weird to me. deleteOnCrash() perhaps? markForDeletionOnCrash()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.