[Webkit-unassigned] [Bug 31718] Framework to show form validation message for invalid controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31718





--- Comment #45 from Kent Tamura <tkent at chromium.org>  2010-11-03 23:41:15 PST ---
(From update of attachment 72157)
View in context: https://bugs.webkit.org/attachment.cgi?id=72157&action=review

Thank you for reviewing!!!

>> WebCore/html/ValidationMessage.cpp:45
>> +    hideMessage();
> 
> Cancel timer here?

We don't need to cancel explicitly.  It is canceled by m_timer destruction.

>> WebCore/html/ValidationMessage.cpp:55
>> +    if (m_message.isEmpty()) { } // FIXME: Construct validation message UI.
> 
> Probably should just remove this, leaving just a FIXME.

ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.