[Webkit-unassigned] [Bug 48308] Too precise serialization from floating point number to string for "number" input elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48308





--- Comment #30 from Kent Tamura <tkent at chromium.org>  2010-11-03 17:59:48 PST ---
(From update of attachment 72653)
View in context: https://bugs.webkit.org/attachment.cgi?id=72653&action=review

> WebCore/html/InputType.cpp:240
> +double InputType::stepBaseWithDecimalPlaces(unsigned* decimalPlaces) const

If you assume decimalPlaces must be non-0,
 - add ASSERT(decimalPlaces) and document it in the header, or
 - use unsigned&.

> WebCore/html/InputType.cpp:243
> +    stepBase();

"retrurn stepBase()" ?

> WebCore/html/InputType.cpp:284
> +    *decimalPlaces = 0;

ASSERT or unsigned&.

> WebCore/html/parser/HTMLParserIdioms.cpp:101
> +    *decimalPlaces = 0;

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.