[Webkit-unassigned] [Bug 48684] Should make use of purge priorities for different resource types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 13:54:42 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48684





--- Comment #12 from Pratik Solanki <psolanki at apple.com>  2010-11-03 13:54:42 PST ---
(In reply to comment #11)
> (From update of attachment 72581 [details])
> > WebCore/loader/CachedCSSStyleSheet.h:63
> >      protected:
> > +        virtual PurgePriority resourcePurgePriority() const { return PurgeLast; }
> > +
> >          RefPtr<TextResourceDecoder> m_decoder;
> >          String m_decodedSheetText;
> 
> I think these members should be private, not protected, unless there is a derived class that needs to access these.

Interesting. I didn't know private functions could be overridden by subclasses and that it would work as expected. Yes, making it private would be much better. New updated patch coming up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list