[Webkit-unassigned] [Bug 48918] Crashes in WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair() when deleting multiple lines of text.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 13:42:51 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48918





--- Comment #6 from jpu at apple.com  2010-11-03 13:42:51 PST ---
(In reply to comment #5)
> (From update of attachment 72844 [details])
> It’s extremely inefficient to use TextIterator’s node() function on every node in a range you are iterating. The TextIterator::range() function is far more efficient. We should probably have a comment about that in TextIterator.h and perhaps even rename node() to deprecatedNode().
> 
> This code change is OK, but I worry that removeSpellAndCorrectionMarkersFromWordsToBeEdited can be pathologically slow with a large selection because of the use of TextIterator::node().

Thanks for reviewing, Darin. I have create bug #48949 to track replacing Consider replacing TextIterator::node() with TextIterator::range().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list