[Webkit-unassigned] [Bug 38636] Object.defineProperty doesn't respect attributes when applied to the Global Object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38636





--- Comment #6 from Oliver Hunt <oliver at apple.com>  2010-11-03 11:58:58 PST ---
(From update of attachment 72562)
View in context: https://bugs.webkit.org/attachment.cgi?id=72562&action=review

> JavaScriptCore/runtime/JSGlobalObject.cpp:-174
> -    JSValue valueBefore = getDirect(propertyName);
> -    PutPropertySlot slot;
> -    JSVariableObject::put(exec, propertyName, value, slot);
> -    if (!valueBefore) {
> -        JSValue valueAfter = getDirect(propertyName);
> -        if (valueAfter)
> -            JSObject::putWithAttributes(exec, propertyName, valueAfter, attributes);
> -    }

This old code was somewhat convoluted and I'm not sure why -- before we remove it I think we should really understand why the current code behaves as it does.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.