[Webkit-unassigned] [Bug 46191] Make collapsed borders in tables work with different block flows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46191


Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72838|review?                     |review+
               Flag|                            |




--- Comment #2 from Dave Hyatt <hyatt at apple.com>  2010-11-03 10:58:19 PST ---
(From update of attachment 72838)
View in context: https://bugs.webkit.org/attachment.cgi?id=72838&action=review

r=me

> WebCore/rendering/RenderTableCell.cpp:666
> +CollapsedBorderValue RenderTableCell::collapsedLeftBorder() const
> +{
> +    if (table()->style()->isHorizontalWritingMode())
> +        return table()->style()->isLeftToRightDirection() ? collapsedStartBorder() : collapsedEndBorder();
> +    return table()->style()->isFlippedBlocksWritingMode() ? collapsedAfterBorder() : collapsedBeforeBorder();

I would cache table()->style() in a local and then use it in the three places where you acccess it.  Ditto for collapsedRight/Top/BottomBorder.

> WebCore/rendering/RenderTableCell.cpp:743
> +int RenderTableCell::borderHalfRight(bool outer) const
> +{
> +    if (table()->style()->isHorizontalWritingMode())
> +        return table()->style()->isLeftToRightDirection() ? borderHalfEnd(outer) : borderHalfStart(outer);
> +    return table()->style()->isFlippedBlocksWritingMode() ? borderHalfBefore(outer) : borderHalfAfter(outer);

Same comment.  Cache table()->style() in a local.  Same for all of the borderHalf*** functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.