[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 3 09:11:06 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #33 from Tor Arne Vestbø <vestbo at webkit.org>  2010-11-03 09:10:59 PST ---
(In reply to comment #32)
> (In reply to comment #30)
> > I'd prefer to stay with the XP-defines or add another level to make it clearer what they mean but to map them to the XP-defines.
> 
> That makes sense to me.

So we could have:

#define NESCAPE_PLUGIN_PLATFORM(WTF_FEATURE) (defined XP_##WTF_FEATURE && XP_##WTF_FEATURE)

And then either use NESCAPE_PLUGIN_PLATFORM(UNIX) all around, or #define XP_X11 XP_UNIX and use the clearer NESCAPE_PLUGIN_PLATFORM(X11)

> 
> > The downside to this is of course that we have platform-detection code both in npapi.h and Platform.h. Would it make sense to have npapi.h use the macros from Platform.h?
> 
> npapi.h can't use Platform.h. npapi.h is an API header that plugins include, and plugins don't have access to Platform.h.

Right

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list