[Webkit-unassigned] [Bug 45325] SVG Animate / Animate transform not animating after change via JS API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45325





--- Comment #5 from Robin Qiu <robin.qiu at torchmobile.com.cn>  2010-11-03 02:33:10 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=72801)
 --> (https://bugs.webkit.org/attachment.cgi?id=72801&action=review) [details] [details]
> > Patch v1
> > 
> > Tested, no regression. The behavior similar to Opera now.
> > 
> > But I don't know how to write a test case for this patch, because the "animVal" always returns orginal value even after attribute is changed.
> 
> We have no animVal support, so you might want to use the animation snapshot API to test this.
> See the existing testcases in svg/animations/ that make us of it.
> 
> I think you want to declare a SMIL animation element, then change an animation attribute dynamically, then call beginElement. Ideally you'd test eg. a color transition with dur="1s" from red to green, and snapshot the animation values at 0s, 0.5s and 1s.
> 
> Without your patch the animation wouldn't run, and no change in baseVal would be visible.
> (Note: that we're currently changing the baseVal, not the animVal, so this is going to work, as long as we have no animVal support, and then we'll need to revisit the animation testcases again anyway).
> 
> Can you give that a try?

Thanks for your so quick reply!
I'll do that right now. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.