[Webkit-unassigned] [Bug 48212] SVG FELighting performance issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48212


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72664|review?                     |review+
               Flag|                            |




--- Comment #14 from Dirk Schulze <krit at webkit.org>  2010-11-02 14:25:54 PST ---
(From update of attachment 72664)
View in context: https://bugs.webkit.org/attachment.cgi?id=72664&action=review

r=me with little style changes.

> WebCore/platform/graphics/filters/FELighting.cpp:178
> +inline void FELighting::inlineSetPixel(int offset, LightingData& data, LightSource::PaintingData& paintingData,
> +    int lightX, int lightY, float factorX, float factorY, IntPoint& normal2DVector)

align the int's

> WebCore/platform/graphics/filters/FELighting.cpp:227
> +void FELighting::setPixel(int offset, LightingData& data, LightSource::PaintingData& paintingData,
> +    int lightX, int lightY, float factorX, float factorY, IntPoint& normalVector)

align the int's.

> WebCore/platform/graphics/filters/FELighting.h:76
> +    inline void inlineSetPixel(int offset, LightingData&, LightSource::PaintingData&,
> +        int lightX, int lightY, float factorX, float factorY, IntPoint& normalVector);

please align the ints

> WebCore/platform/graphics/filters/FELighting.h:80
> +    void setPixel(int offset, LightingData&, LightSource::PaintingData&,
> +        int lightX, int lightY, float factorX, float factorY, IntPoint& normalVector);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.