[Webkit-unassigned] [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48812





--- Comment #7 from Charles Reis <creis at chromium.org>  2010-11-02 12:41:25 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > This also seems a little weird as navigation in a subframe will be checking against the top-level back/forward item for the whole page...
> 
> (I meant with regards to the patch)

Subframe navigations won't hit this code, will they?  "item" only gets assigned if the load is a back/forward and the frame is the mainFrame, based on the check on line 2352.

Also, "item" is used to update the back/forward list on line 2383. It seems more likely to hit confusion about subframe vs mainframe if we assign something from history() to backForward() rather than from backForward() to backForward().

Although, looking again at line 2383, it looks like it has changed recently from goToItem to setCurrentItem, so it might be redundant to call setCurrentItem(currentItem()).  I'll take another look at the buggy behavior to try to understand what should be happening.


(In reply to comment #4)
> (From update of attachment 72616 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72616&action=review
> 
> r- for lack of a regression test.

I'm in the process of writing a layout test, using layoutTestController.dumpBackForwardList() to check for the right state at the end.  I haven't figured out how to get a layout test to hit this branch of FrameLoader, though.  Is there a way to tell the browser to go back twice quickly without waiting for the first navigation to commit?  Or to force the first back navigation to cancel?  I'll keep looking, but any tips would be appreciated.

Thanks,
Charlie


> 
> > ChangeLog:8
> > +        * ../../WebCore/loader/FrameLoader.cpp:
> 
> "../../" is wrong. Please add an explanation of the fix to ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.