[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127





--- Comment #29 from Tor Arne Vestbø <vestbo at webkit.org>  2010-11-02 10:40:24 PST ---
(In reply to comment #25)
> (In reply to comment #21)
> > I don't think it will become an ifdef hell - we'll have something like
> > 
> > #if PLATFORM(MAC)
> > #define PLUGIN_ARCHITECTURE_MAC 1
> > #elif PLATFORM(WIN)
> > #define PLUGIN_ARCHITECTURE_WIN 1
> > #elif PLATFORM(QT)
> > #if (qt for mac)
> > #define PLUGIN_ARCHITECTURE_MAC 1
> > #elif (qt for x11)
> > #define PLUGIN_ARCHITECTURE_X11
> > #endif
> > #endif
> > 
> > I also think that this patch should be split up. The quirk refactoring could definitely be done as a separate patch.
> 
> What would it solve? The ifdef hell would be in NetscapePluginX11.cpp
> with a lot of code guarded by #if PLATFORM(QT), #if PLATFORM(GTK), ...
> Unfortunately the plugin implementation is depends on the arch and on
> the port as well.

I agree with Anders here, we should have a NetscapePluginX11.cpp with #if PLATFORM(QT), #if PLATFORM(GTK) guards for the port-specific bits. Even if there will be a few of those guards, it's certainly better than the approach we have in WebCore now with PluginViewQt and PluginViewGtk. 

PluginViewMac in WebCore shows how the Qt and Wx port shares most stuff, and many of those port-specific bits could be put into widget or hidden somewhere closer to where the difference really is.

Regarding the name X11 is preferable, it would clash a bit with XP_UNIX, but I don't mind that. 

I'd also split up this patch as others say, the renaming etc can be done separately from sharing the quirks between WebKit and WebKit2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.