[Webkit-unassigned] [Bug 47812] V8 binding for DOMSettableTokenList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47812





--- Comment #5 from Kenichi Ishibashi <bashi at google.com>  2010-11-02 00:42:18 PST ---
Hi Erik,

Thank you for your comment.

(In reply to comment #4)
> Also, why do we need custom indexedPropertyGetter? It wasn't needed for classList. The codegen knows how to generate this.

It looks like that the codegen for V8 bindings does not consider the inheritance of the interface and doesn't generate indexedPropertyGetter automatically. On the other hand, the codegen for JSC consider the inheritance of the interface and generate getter function automatically. To manage these two case, we need to custom function.

> > WebCore/bindings/v8/custom/V8DOMSettableTokenListCustom.cpp:39
> > +    return v8String(list->item(index));
> 
> This does not look right since we should return null when index is out of bounds. ([ConvertNullStringTo=Null]  in the idl)

Yes, I've made a mistake and I'll fix it in the patch for https://bugs.webkit.org/show_bug.cgi?id=29363. Thank you for correcting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.