[Webkit-unassigned] [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48110


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72622|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Nikolas Zimmermann <zimmermann at kde.org>  2010-11-02 00:15:38 PST ---
(From update of attachment 72622)
View in context: https://bugs.webkit.org/attachment.cgi?id=72622&action=review

This looks great, especially the tests, though some nitpicks:

> WebCore/rendering/RenderObject.h:1006
> +inline float adjustFloatForAbsoluteZoom(float value, RenderObject* renderer)
>  {
> -    rect.setX(adjustForAbsoluteZoom(rect.x(), renderer));
> -    rect.setY(adjustForAbsoluteZoom(rect.y(), renderer));
> -    rect.setWidth(adjustForAbsoluteZoom(rect.width(), renderer));
> -    rect.setHeight(adjustForAbsoluteZoom(rect.height(), renderer));
> +    return adjustFloatForAbsoluteZoom(value, renderer->style());
>  }

This helper function seems useless.

> WebCore/rendering/RenderObject.h:1030
> +    rect.setX(adjustFloatForAbsoluteZoom(rect.x(), renderer));
> +    rect.setY(adjustFloatForAbsoluteZoom(rect.y(), renderer));
> +    rect.setWidth(adjustFloatForAbsoluteZoom(rect.width(), renderer));
> +    rect.setHeight(adjustFloatForAbsoluteZoom(rect.height(), renderer));

Just cache the RenderStyle* style = renderer->style() here, and pass it instead of renderer to adjustFloatForAbsoluteZoom.

> WebCore/rendering/style/RenderStyle.h:1322
> +    float zoomFactor = style->effectiveZoom();
> +    return value / zoomFactor;

No need for this local variable zoomFactor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.