[Webkit-unassigned] [Bug 29363] Support for <output> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29363





--- Comment #16 from Kenichi Ishibashi <bashi at google.com>  2010-11-01 23:19:51 PST ---
(From update of attachment 72626)
View in context: https://bugs.webkit.org/attachment.cgi?id=72626&action=review

Kent-san,

Thank you your quick review. I'll revise the patch but I have a question on tests for form control enumeration. If I understand the spec correctly, the spec <http://www.w3.org/TR/html5/forms.html#category-listed> says that following elements would be listed in elements property of form elements: <button>, <fieldset>, <input>, <keygen>, <object>, <output>, <select>, and <textarea>. But for the current implementation, <fieldset>, <keygen> and <object> are not contained in the elements property. Which behavior should I add in the tests?

>> LayoutTests/fast/dom/HTMLOutputElement/htmloutputelement-validity-expected.txt:1
>> +CONSOLE MESSAGE: line 25: true
> 
> Something wrong.

I'm sorry I forgot delete this debug information. I'll remove this.

>> WebCore/ChangeLog:7
>> +        Support for <output> element
> 
> No need to use entity references :-)

Oh, thank you notifying this. I'll fix this.

>> WebCore/html/HTMLOutputElement.h:44
>> +    virtual bool isEnumeratable() const { return true; }
> 
> Need a test for this.
> However, I couldn't find existing tests for from control enumeration.  We might need a new test for all of form control types.
> 
> These override functions (isEnumeratable, willValidate, reset, childrenChanged) should be moved to private:.

I've moved these override functions to private except for willValidate() since it is called by JSHTMLOutputElement class.

I'm going to try to write tests for form control enumeration but I have some questions, as I mentioned above. It is great if you could give some advice on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.