[Webkit-unassigned] [Bug 48817] Chromium: Propagate a document value changed notification on scroll.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48817


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72621|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from chris fleizach <cfleizach at apple.com>  2010-11-01 23:00:41 PST ---
(From update of attachment 72621)
View in context: https://bugs.webkit.org/attachment.cgi?id=72621&action=review

looks ok otherwise.

> WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:52
> +    if (obj->roleValue() == ScrollBarRole && notification == AXValueChanged) {

i don't think obj->roleValue() is a strong enough check for doing a static_cast. If not already, I can see something like <div role="scrollbar"> in the future.

You should add a method to AccessibilityScrollbar that says "isNativeScrollbar()" or something to that effect, that will allow you to safely cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.