[Webkit-unassigned] [Bug 48169] [FileSystem] Support not creating directories when queried by inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48169





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2010-11-01 20:54:16 PST ---
(From update of attachment 72624)
View in context: https://bugs.webkit.org/attachment.cgi?id=72624&action=review

> WebKit/chromium/src/LocalFileSystemChromium.cpp:62
> +    ASSERT(context->isDocument());

ASSERT(context && context->isDocument())?

> WebCore/fileapi/LocalFileSystem.h:56
> +    void readFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type, long long size, PassOwnPtr<AsyncFileSystemCallbacks>);

readFileSystem may sound like reading some contents of the filesystem... how about queryFileSystem?  (readFileSystem sounds ok to me too, just giving an idea.)

> WebCore/platform/AsyncFileSystem.h:69
> +    // Opens a new file system. |create| specifies whether or not to create the path if it does not already exists.

nit: we do not use || in WebKit as far as I know..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.