[Webkit-unassigned] [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48110


Cosmin Truta <ctruta at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72622|                            |review?, commit-queue?
               Flag|                            |




--- Comment #6 from Cosmin Truta <ctruta at chromium.org>  2010-11-01 20:27:20 PST ---
Created an attachment (id=72622)
 --> (https://bugs.webkit.org/attachment.cgi?id=72622&action=review)
Fix and layout test

In response to Niko's comment in bug 48640:

> Hmm, as I wrote in my last comment, the usage of enclosingIntRect is the actual problem. We shouldn't do that at all, but give back a FloatRect, according to the CSS OM API?

Done.

I am still puzzled by the discrepancy between zoomCount=2 and zoomCount=3. With zoomCount=1,2 the results are well-behaved, within a very small distance from the expected value (with delta=1.0e-5 -- very decent!). On the other hand, with zoomCount=3,4,5... the errors grow wilder, suddenly, and even delta=0.5 is not good enough for some of the coordinates.

I wonder if some precision is being lost accidentally, somewhere inside WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.