[Webkit-unassigned] [Bug 48169] [FileSystem] Support not creating directories when queried by inspector.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 20:09:15 PDT 2010


--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org>  2010-11-01 20:09:15 PST ---
(From update of attachment 72617)
Looks good to me.

View in context: https://bugs.webkit.org/attachment.cgi?id=72617&action=review

> WebKit/chromium/src/LocalFileSystemChromium.cpp:63
> +    if (context->isDocument()) {

Might be better to drop this if and have ASSERT(context->isDocument()) instead?

> WebCore/fileapi/LocalFileSystem.h:56
> +    void readFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type, long long size, PassOwnPtr<AsyncFileSystemCallbacks>, bool synchronous = false);

We won't need synchronous flag for this method.

> WebCore/platform/AsyncFileSystem.cpp:56
> +void AsyncFileSystem::openFileSystem(const String& basePath, const String& storageIdentifier, Type type, bool create, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

You'll need to omit unused parameter name (s/bool create/bool/) to avoid compile warnings.

> WebCore/platform/AsyncFileSystem.h:70
> +    static void openFileSystem(const String& basePath, const String& storageIdentifier, Type, bool, PassOwnPtr<AsyncFileSystemCallbacks>);

Please include parameter name (s/bool/bool create/) since otherwise it doesn't give idea what to specify.  Also it might be good to have some short description about this new flag.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list