[Webkit-unassigned] [Bug 48798] Add RealtimeAnalyserNode files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 19:01:39 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48798


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72589|review?                     |review+
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2010-11-01 19:01:38 PST ---
(From update of attachment 72589)
Looks fine. The hardcoded fetches of input and output 0 in process() and pullInputs() are a little subtle, but I see that they make sense because this node is defined as having one output and one input. Since all of the associated code is self-contained in the .cpp, I don't think it's worth asking for assertions about this fact.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list