[Webkit-unassigned] [Bug 48809] New: Chromium WebKit API needs WebFrame::lastCommittedHistoryItem()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 1 17:14:17 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=48809

           Summary: Chromium WebKit API needs
                    WebFrame::lastCommittedHistoryItem()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
               URL: N/A
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: creis at chromium.org
                CC: brettw at chromium.org


As part of http://code.google.com/p/chromium/issues/detail?id=58082, we discovered that Chromium's RenderView is sending UpdateState messages to the browser process using the page ID of the last committed history item but the state from the previous history item.  These are not necessarily the same history item, if multiple navigations have been attempted but have not committed.  For example, visiting multiple pages and then holding down the "back" keyboard shortcut can lead to corrupted UpdateState messages that have the original page's page ID but an intermediate page's state.

The UpdateState message should instead be sent with the state of the last committed history item, but the Chromium WebKit API does not currently expose this.  I propose adding WebFrame::lastCommittedHistoryItem() method, which will obtain the desired history item from BackForwardListClientImpl.  WebFrameImpl will have to notify BackForwardListClientImpl when history items commit, so that BackForwardListClientImpl can keep track of the correct item.

I have a draft changelist that shows that this fixes one of the key issues in Chromium bug 58082.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list