[Webkit-unassigned] [Bug 48744] REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for image dup detection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48744





--- Comment #5 from Kent Tamura <tkent at chromium.org>  2010-11-01 06:41:43 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > Because It seems rebaseline-chromium-webkit-tests has code to support non-Chromium port targets.  I don't know if it works.
> 
> Ports that don't care about the tolerance setting will just ignore the field in the options object. new-run-webkit-tests always sets tolerance, it's up to each port to do something with it (only the Mac port respects it), and that hasn't been an issue.

Ah, right.
So, the ideal fix is that ImageDiff of the host port runs with the tolerance value of the target port?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.