[Webkit-unassigned] [Bug 48620] [Qt] WebKit2 needs to support historyitem, QWKHistoryItem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48620





--- Comment #3 from Juha Savolainen <juha.savolainen at weego.fi>  2010-11-01 05:36:52 PST ---
(In reply to comment #2)
> (From update of attachment 72299 [details])

> > WebKit2/UIProcess/API/qt/qwkhistory.cpp:59
> > +QString QWKHistoryItem::title() const
> > +{
> > +    return WKStringCopyQString(WKBackForwardListItemCopyTitle(d->m_backForwardListItem));
> > +}
> 
> I think that you are leaking here. As you are not freeing the WKString.

Also I noticed that I forgot to do checkings:
    if (!d->m_backForwardListItem)
        return QString();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.