[Webkit-unassigned] [Bug 39972] Fix style errors of dtoa

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 22:53:13 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39972





--- Comment #3 from Kent Tamura <tkent at chromium.org>  2010-05-31 22:53:13 PST ---
Thank you for looking at the patch.

(In reply to comment #2)
> (From update of attachment 57498 [details])
> JavaScriptCore/wtf/dtoa.cpp:210
>  +  static ALWAYS_INLINE uint32_t* storeInc(uint32_t* p, uint16_t high, uint16_t low)
> I think this is a refactoring rather than a style fix. I guess we can remove the style error just by adding spaces after commas?

It's also a style fix though check-webkit-style doesn't complain it.

http://webkit.org/coding/coding-style.html
> 11. Prefer const to #define. Prefer inline functions to macros.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list