[Webkit-unassigned] [Bug 39958] [Qt] TextBreakIteratorQt performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39958


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57508|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-05-31 19:39:32 PST ---
(From update of attachment 57508)
I would personally have used previousString and not previousstring, as it fits with how we normally name variables, but that is a nit. I'm r+, but please let this sit for at least a day so that others have the change to have a look at it as well.

WebCore/ChangeLog:5
 +          [Qt] TextBreakIterator QT performance
It is called Qt, not QT. QT is short for QuickTime, which can cause confusion as it is used other places in WebKit.

Did you measure if the inlining made any difference?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.