[Webkit-unassigned] [Bug 39958] [Qt] TextBreakIteratorQt performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39958





--- Comment #8 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-05-31 18:31:25 PST ---
Btw, remove the line with only //

Please write previousLength instead of prevlength, etc/

57         if (prevstring == string && prevlength == length && prevtype == type) {

Here is it probably better to first then type, then length and then string

 58             // We are the same!

// Same as last time, reuse iterator. 

 59             iterator->toStart();
 60         } else {

 // As the boundaries is often recalculated for the same string due to ... store the iterator for reuse.

 61             *iterator = QTextBoundaryFinder(type, (const QChar *)string, length, buffer, sizeof(buffer));
 62             prevstring = string;
 63             prevlength = length;
 64             prevtype = type;
 65         }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.