[Webkit-unassigned] [Bug 39962] Remove hand-rolled JSC bindings for CanvasRenderingContext2D

Mon May 31 10:58:33 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39962

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57479|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #4 from Darin Adler <darin at apple.com>  2010-05-31 10:58:33 PST ---
(From update of attachment 57479)
Great change!

> +        No new tests as there is no new functionality.

Are there tests for each of these overload cases? If not, then I think we do need tests, even though these code paths are not new. It looks to me like some of these hand-written bindings have different handling for things like too many arguments. It would be straightforward to write some tests that cover all these cases, and I'd like to see that to provde that the hand-rolled code did not behave any differently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.