[Webkit-unassigned] [Bug 30567] add support for exporting HTTP Archive format in Resources panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30567


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57474|review?                     |
               Flag|                            |




--- Comment #11 from Pavel Feldman <pfeldman at chromium.org>  2010-05-31 10:15:32 PST ---
(From update of attachment 57474)
1. I would convert it to a prototype-based object with following usage: new WebInspector.HAREntry(resource).build();
2. I'd also like to see a test for it.

WebCore/inspector/front-end/Resource.js:90
 +          delete this._queryParameters;
Consider renaming to this._parsedQueryParameters

WebCore/inspector/front-end/Resource.js:395
 +          return WebInspector.Resource.headerValue(this.requestHeaders, headerName);
consider making private instance method

WebCore/inspector/front-end/Resource.js:406
 +          delete this._formParameters;
this._parsedFormParameters

WebCore/inspector/front-end/Resource.js:452
 +          return this._queryParameters = WebInspector.Resource.parseParameters(queryString);
Also private instance method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.