[Webkit-unassigned] [Bug 39821] [EFL] Add Context Menu support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39821


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57401|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-05-31 08:39:38 PST ---
(From update of attachment 57401)
Please take these comments into account

WebCore/platform/efl/ContextMenuEfl.cpp:36
 +          static_cast<ContextMenuClientEfl*>(controller()->client());
Put this on one line please

WebCore/platform/efl/ContextMenuEfl.cpp:45
 +          static_cast<ContextMenuClientEfl*>(controller()->client());
here as well

WebCore/platform/efl/ContextMenuEfl.cpp:75
 +      // Ref counting remains the same, just pass it and remove our ref, so it
ref count remainds the same, that is what you want to say right?

WebCore/platform/efl/ContextMenuItemEfl.cpp:40
 +      // it's inside WebKit that this initialization is done, as WebCore doesn't
Comments start with capital letter and ends with a dot/punctuation mark.

WebKit/efl/WebCoreSupport/ContextMenuClientEfl.h:53
 +      PlatformMenuDescription newPlatformDescription(ContextMenu*);
what about createPlatformDescription ?

WebKit/efl/ewk/ewk_contextmenu.cpp:114
 +      // don't care about title and submenu as they're not used after this point
Capital + dot please

WebKit/efl/ewk/ewk_contextmenu.h:68
 +      // these are new tags! not a part of api!!!!
How so? You should probably make a better comment

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.