[Webkit-unassigned] [Bug 39944] [GTK] GtkLauncher should support relative file paths

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 31 02:37:01 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39944


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-31 02:37:01 PST ---
Attachment 57444 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/GtkLauncher/main.c:191:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/GtkLauncher/main.c:193:  Declaration has space between * and variable name in GFile* gfile  [whitespace/declaration] [3]
WebKitTools/GtkLauncher/main.c:193:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/GtkLauncher/main.c:197:  Declaration has space between * and variable name in gchar* full_path  [whitespace/declaration] [3]
WebKitTools/GtkLauncher/main.c:197:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/GtkLauncher/main.c:197:  full_path is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/GtkLauncher/main.c:201:  Declaration has space between * and variable name in gchar* file_url  [whitespace/declaration] [3]
WebKitTools/GtkLauncher/main.c:201:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/GtkLauncher/main.c:201:  file_url is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/GtkLauncher/main.c:223:  Declaration has space between * and variable name in gchar* file_url  [whitespace/declaration] [3]
WebKitTools/GtkLauncher/main.c:223:  file_url is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/GtkLauncher/main.c:226:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/GtkLauncher/main.c:229:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 13 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list