[Webkit-unassigned] [Bug 39945] New: [PATCH] compilation error with clang in JSDOMBinding.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39945

           Summary: [PATCH] compilation error with clang in JSDOMBinding.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ogoffart at kde.org


webkit/WebCore/bindings/js/JSDOMBinding.h:229:20: error: no viable conversion from 'WebCore::JSNode *' to 'JSC::JSValue'

webkit/JavaScriptCore/runtime/JSValue.h:807:21: note: candidate constructor not viable: cannot convert argument of incomplete type 'WebCore::JSNode *' to 'JSC::JSCell *'
    inline JSValue::JSValue(JSCell* ptr)



     JSNode is only forward declared at this point. And since neither 
     "wrapper" nor JSValue are type-dependent. Compilers should report errors 
     at the first compilation pass. 

     The fix is to move the conversion the line above, as the call to the 
     function getCachedDOMNodeWrapper is type-dependent, the conversion will 
     happen at template-instantiation time. 

     See also http://llvm.org/bugs/show_bug.cgi?id=7244

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.