[Webkit-unassigned] [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35530


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57421|review?                     |review+
               Flag|                            |




--- Comment #38 from Darin Adler <darin at apple.com>  2010-05-30 11:06:48 PST ---
(From update of attachment 57421)
These are fine except for the "E" prefix. They should be "DirectionForward" not "EDirectionForward". I know the enums currently have names with "E" prefixes, but it's not our standard coding style and pretty ugly!

I'm going to say r=me assuming this doesn't break the build, but I don't like all that "E".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.