[Webkit-unassigned] [Bug 38918] add a FancyReviewQueue to upload r? patches to rietveld

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38918


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56910|review?                     |review+
               Flag|                            |




--- Comment #24 from Adam Barth <abarth at webkit.org>  2010-05-29 09:40:18 PST ---
(From update of attachment 56910)
Minor nits below.  You should feel free to either address them before landing or in a follow-up patch.

WebKitTools/Scripts/webkitpy/common/net/rietveld.py:77
 +          issue, patchset = upload.RealMain(args, data=diff)
I don't quite understand this change, but ok.

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:329
 +          comment_text = "Rejecting patch %s from rietveld-queue." % patch.id()
I still worry that this message is cryptic and folks won't understand it.  We can iterate after landing though.

WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py:39
 +      def _error_message_for_bug(tool, status_id, script_error):
This isn't quite the right place for this method.  StepSequenceErrorHandler is just an interface definition.  It shouldn't have any implementations.  We need to create an intermediate class that inherits from StepSequenceErrorHandler that the queues inherit from.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.