[Webkit-unassigned] [Bug 38156] many webkit-patch commands fail in a non-svn tracking git checkout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38156


Chris Jerdonek <cjerdonek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57369|review?                     |review+
               Flag|                            |




--- Comment #13 from Chris Jerdonek <cjerdonek at webkit.org>  2010-05-28 20:43:53 PST ---
(From update of attachment 57369)
Thanks for your responses.  A couple final comments for you to consider before landing.  r=me

> +        raise ScriptError(message='Can\'t find a branch to diff against. %s branches do not exist.' % "and".join(remote_branch_refs))

Looks like this needs to be " and ".  You can also go back to double quotes now if you want. :)

> +    def tearDown(self):
> +        # Change back to a valid directory so that later calls to os.getcwd() do not fail.
> +        os.chdir(detect_scm_system(os.path.dirname(__file__)).checkout_root)

I would have returned to the original directory to be consistent with the philosophy
of tests leaving no trace behind.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.