[Webkit-unassigned] [Bug 39721] [chromium] Upstream layout tests expectations for Geolocation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39721





--- Comment #12 from Victor Wang <victorw at chromium.org>  2010-05-28 14:37:45 PST ---
Personally, I prefer not having baselines in platform/chromium. For now, since the fallback paths are chromium-linux->chromium-win->chromium-mac, if baselines for all three ports are same, then the baseline would be in chromium-mac and chromium-mac is serving the same purpose as platform/chromium.

I think having baselines in platfomr/chromium may add extra maintenance work.
For example, if a baseline for all ports are same but latter linux has a different baseline, then in addition to add new linux baseline, we also need to remove baseline from platform/chromium and add it to platform/chromium-mac.
It makes rebaseline tool little harder when it tries to rebaseline for one platform and the tool needs to figure out where to add new baseline. I agree these issues could be resolved by making rebaseline smarter, but don't feel it worth the effort to do that, at least for now. I prefer keeping it simple and just use the existing path, thoughts?

(In reply to comment #11)
> (In reply to comment #10)
> > If there's a good reason platform/chromium can't be in the search path for Linux, Win, and Mac, then we need to delete everything from that directory.  (IIRC, there are a bunch of other expected results in there!)
> > 
> > If there's not, we should probably change the re-baselining tool, send a FYI email to chromium-dev, and optionally create a script to move all the duplicate files in -mac and -win to the shared folder.
> > 
> > I hope the answer is the latter.  :-)
> 
> platform/chromium is in the search path on all three platforms. It's fine to put files that are the same on all three Chromium ports but different from upstream there.
> 
> I thought the rebaselining tool automatically dealt with this, but I could be wrong.
> 
> Copying victorw for thoughts on this ... (watch me pass the buck!)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.