[Webkit-unassigned] [Bug 35350] DumpRenderTree should allow tests with modal dialogs

Fri May 28 14:22:36 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=35350

Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dimich at chromium.org

--- Comment #3 from Dmitry Titov <dimich at chromium.org>  2010-05-28 14:22:36 PST ---
I think we need someone more familiar with Cocoa to take a look. Feel free to flip r? up.

I see you disabling the tests that fail anyways, considering this is the first patch and  you are on a path to implement the showModalDialog for Win and Chromium as well (at least), it looks as right thing to do and prevents proliferation of platform-specific expectations.

My couple of tiny nits:

LayoutTests/ChangeLog:15
 +          that the method is undefined.  Added mac specific expected output files for all those tests.
That last sentence is probably not entirely correct now. Maybe something like this:  "Modified the tests accordingly and will do more followup (see bug 12345)"

LayoutTests/ChangeLog:67
 +          if deemed important enough.
To add a test for existing functionality is always super-important :-) I think it's best to remove "if deemed important enough"...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.