[Webkit-unassigned] [Bug 39625] [Qt] Sending a QInputMethodEvent::Selection event forces the Editor to go into Composition mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39625





--- Comment #8 from Robert Hogan <robert at webkit.org>  2010-05-28 13:22:04 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=57275)
 --> (https://bugs.webkit.org/attachment.cgi?id=57275) [details] [details]
> > Patch
> 
> Couple of points:
> 
> In QwebPage.cpp:
> 1) If the preedit string was not empty and this wasn't a selection event, we are changing the present 
> composition to go from 0 to preedit.length. It seems wrong and unneccessary to touch the composition in this case.

Removing it doesn't appear to impact any layout tests, and the unit test I removed from tst_qwebpage was based on the assumption that an event with a preedit would not affect composition. But if we remove it we will only call setComposition() on selection events. You sure that's correct? Shouldn't a populated preedit put us into composition mode and update the current composition?

> 2) If either the preedit string is empty or the editor doesn't have an ongoing composition, it doesn't
>  seem necessary to change the start and end positions in this case either. These should only be changed
>  if we had received a selection event.

Of course, thanks for that!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.