[Webkit-unassigned] [Bug 39624] --squash should be replaced with --git-commit=*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 12:36:26 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39624





--- Comment #19 from Ojan Vafai <ojan at chromium.org>  2010-05-28 12:36:26 PST ---
(In reply to comment #16)
> (In reply to comment #5)
> > (From update of attachment 56939 [details] [details])
> > As per discussion on #webkit and webkit-dev, I'm changing this patch to squash by default and prompt instead of erroring out in cases where squashing will actually squash multiple commits.
> 
> Can you provide a direct link to the webkit-dev e-mail saying what the final decision was?  I thought the decision was not to use "*" anymore, but the latest patch (patch #3) still has some references to *.

Ugh. I just missed a couple cases. Most of them were cases where we assertRaises and putting --git-commit=* or not both result in raising an error.

Sorry for the confusion. There are no more "*"s anywhere. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list