[Webkit-unassigned] [Bug 39883] Adding tests to canvas.html performance test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39883


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57350|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2010-05-28 12:34:02 PST ---
(From update of attachment 57350)

> +
> +function doStrokeTextTests() {
> +    log("===== StrokeText Tests =====");
> +    var strokeTextFunc = function(obj, str, x, y) { obj.strokeText(str, x, y); };
> +    for (var i = 1; i < 1001; i *= 10)
> +        textTest(strokeTextFunc, i);
One last comment: It would be nice if these were written in a more async manner to allow for any gc's to happen as done in other tests.

Example:

function doStrokeTextTests() {
    log("===== StrokeText Tests =====");
    doNextStrokeTextTest(1);
}

function doNextStrokeTextTest(var lineCount) {
    var strokeTextFunc = function(canvas, str, x, y) { canvas.strokeText(str, x, y); };
    textTest(strokeTextFunc, i);
    lineCount *= 10;
    if (lineCount < 1001)
        window.setTimeout(function () {
                              doNextStrokeTextTest(lineCount);
                          }, idleTimer);
    else {
        log("");
        window.setTimeout(doFillTextTests, idleTimer);
   }
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.