[Webkit-unassigned] [Bug 39654] Backslash is transcoded into yen sign even when non japanese font is specified

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39654





--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2010-05-28 11:45:32 PST ---
(From update of attachment 57007)
> @@ -70,8 +70,8 @@ Font::Font(const FontDescription& fd, short letterSpacing, short wordSpacing)
>      , m_letterSpacing(letterSpacing)
>      , m_wordSpacing(wordSpacing)
>      , m_isPlatformFont(false)
> -    , m_needsTranscoding(fontTranscoder().needsTranscoding(family().family().string()))
>  {
> +    m_needsTranscoding = fontTranscoder().needsTranscoding(*this);
>  }

In general, it isn't a great pattern to pass "this" to external functions from a constructor. The object may still be in some transitional state, and although it's valid 
C++, it may catch the programmer by surprise:
- subclass constructors haven't been invoked yet, and virtual methods table hasn't been swapped to final one yet;
- a reference counted object can still have a refcount of 0, so taking a temporary RefPtr will destroy it from within the constructor;
- post-constructor "init" functions that someone else wrote to avoid these problems haven't run yet;
- etc.

I'm still unclear on the "specified font" concept. The test doesn't check multiple font names (e.g. '"some-windows-only-font", "Times"', or "some-windows-only-font", "MS PGothic"). Is "specified font" inherited from parent nodes?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.