[Webkit-unassigned] [Bug 39859] ScrollView::setFrameRect should not call contentsResized when there is a fixed layout size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39859


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57343|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Daniel Bates <dbates at webkit.org>  2010-05-28 10:53:22 PST ---
(From update of attachment 57343)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index a63213f..7c99717 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,15 @@
> +2010-05-28  Adam Treat  <atreat at rim.com>
> +
> +        Reviewed by Daniel Bates.
> +
> +        Bug #293 and https://bugs.webkit.org/show_bug.cgi?id=39859
> +
> +        Layout is not dependent upon ScrollView::frameRect when useFixedLayout
> +        is true.  No reason to set the needs layout flag in this case.
> +
> +        * platform/ScrollView.cpp:
> +        (WebCore::ScrollView::wheelEvent):

This change log disagrees with both the patch and the description since ScrollView::wheelEven was not modified.

Looks sane to me.

r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.